fix: options missing id #45287
Merged
fix: options missing id #45287
+86
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
MadCcc
approved these changes
Oct 11, 2023
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45287 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 693 692 -1
Lines 11842 11667 -175
Branches 3172 3117 -55
==========================================
- Hits 11842 11667 -175
☔ View full report in Codecov by Sentry. |
|
感觉没有完全解决, 除了PR里面修复的组件, input、select等组件也有同样问题, 希望统一处理一次 |
|
并没有完全解决，radioGroup还是有问题 |
|
radioGroup依旧存在问题。 |
|
@wangyingjie123 @noahge0923 帮忙来个复现开个新issue？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #44505
💡 Background and solution
补了一下文档 label for，发现可以优化一下 options
📝 Changelog
optionsadd missingidprops.options添加id属性支持。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e9df555
This pull request improves the accessibility and code style of the theme picker and the checkbox and radio groups by adding and passing
idprops to the components. It also adds test cases and formats the test files for theCheckbox.GroupandRadio.Groupcomponents. It modifies theThemePicker.tsx,ColorPicker.tsx,RadiusPicker.tsx, andindex.tsxfiles to use theidprops and link the labels with the inputs.🔍 Walkthrough
🤖 Generated by Copilot at e9df555
idprop toCheckbox.Group,Radio.Group,ThemePicker,ThemeColorPicker, andRadiusPickercomponents to improve accessibility (link, link, link, link, link, link, link, link, link, link, link, link, link, link)Radio.Groupcomponent in.dumi/pages/index/components/Theme/index.tsxto useoptionsprop instead ofRadiochildren (link)ThemePicker.tsxandGroup.tsx(link, link)group.test.tsxfiles (link, link)