Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Select fail test case issue cause by aria-label="Search" #45333

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

react-component/select#985

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select fail test case issue cause by aria-label="Search".
🇨🇳 Chinese 修复 Select aria-label="Search" 导致的相关测试失败问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 06885d6

This pull request fixes a form test bug and updates a dependency for better performance. It changes components/form/__tests__/index.test.tsx to match the input name and label, and package.json to use rc-select@14.9.1.

🔍 Walkthrough

🤖 Generated by Copilot at 06885d6

  • Fix a bug in the form test where the input element's accessible name did not match the label text (link)
  • Update the dependency version of rc-select to include a performance fix (link)

@stackblitz
Copy link

stackblitz bot commented Oct 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Preview Is ready

@afc163 afc163 changed the title chore: update select snapshot fix: fix Select fail test case issue cause by aria-label="Search" Oct 13, 2023
@afc163 afc163 mentioned this pull request Oct 13, 2023
20 tasks
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 397.92 KB
./dist/antd-with-locales.min.js 457.23 KB

@argos-ci
Copy link

argos-ci bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 13, 2023, 11:56 AM

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (da23a00) 100.00% compared to head (06885d6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45333   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          692       692           
  Lines        11670     11670           
  Branches      3116      3116           
=========================================
  Hits         11670     11670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit e587a5f into master Oct 13, 2023
108 checks passed
@MadCcc MadCcc deleted the fix/select-snapshot branch October 13, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants