enhance: auto layout hasSider #45361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
MadCcc
approved these changes
Oct 16, 2023
kiner-tang
reviewed
Oct 16, 2023
|
|
||
| const childNodes = toArray(children); | ||
|
|
||
| return childNodes.some((node) => node.type === Sider); |
There was a problem hiding this comment.
type 不是应该是字符串吗？Slider 应该是一个组件吧，这个能相等吗？
There was a problem hiding this comment.
type 是 ReactComponent 类型，包含字符串和方法和特殊 obj
size-limit report 📦
|
kiner-tang
approved these changes
Oct 16, 2023
|
要更新一下快照 |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
snapshot 也修复了： 
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45361 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 692 694 +2
Lines 11667 11674 +7
Branches 3116 3117 +1
=========================================
+ Hits 11667 11674 +7
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolves #44518 #42576
💡 Background and solution
遍历子节点添加
hasSider，不是最优解，比如对 HOC 无效。不过这个应该也能解90% 的 SSR 问题了。📝 Changelog
hasSidercheck to avoid blink in SSR.hasSider以防止在 SSR 场景下的闪烁问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 1cf0df7
The pull request refactors the Layout and Sider components to use React hooks and a separate context file. It also improves the test coverage and the import order for the components. The main files affected are
layout.tsx,Sider.tsx,context.ts,useHasSider.ts, andindex.test.tsx.🔍 Walkthrough
🤖 Generated by Copilot at 1cf0df7
LayoutContextand its interface fromlayout.tsxto a new filecontext.tsfor better modularity and reusability (link, link, link).