Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tour support z-index manager #45425

Merged
merged 3 commits into from Oct 20, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Oct 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tour Support z-index context to manage z-index
🇨🇳 Chinese 漫游式引导组件支持通过 z-index 上下文管理 z-index

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 79c87b3

Added a custom hook and context for Tour component to handle z-index values. This allows nested descriptions and other components to be layered correctly. Added a test case to verify the behavior.

🔍 Walkthrough

🤖 Generated by Copilot at 79c87b3

  • Wrap Tour component with zIndexContext.Provider and pass zIndex prop to RCTour component to use z-index values from context and hook (link)
  • Import useZIndex hook and zIndexContext from ../_util/hooks/useZIndex and ../_util/zindexContext respectively (link)
  • Add test case to check z-index values of nested Tour and Select components (link)
  • Import Select component from antd for test case (link)

@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 399.33 KB (+29 B 🔺)
./dist/antd-with-locales.min.js 458.64 KB (+30 B 🔺)

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bff04cd) 100.00% compared to head (d763d84) 100.00%.
Report is 3 commits behind head on refactor-z-index-context.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           refactor-z-index-context    #45425   +/-   ##
==========================================================
  Coverage                    100.00%   100.00%           
==========================================================
  Files                           697       697           
  Lines                         11732     11733    +1     
  Branches                       3137      3137           
==========================================================
+ Hits                          11732     11733    +1     
Files Coverage Δ
components/tour/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit 193c3b4 into refactor-z-index-context Oct 20, 2023
88 checks passed
@kiner-tang kiner-tang deleted the feat-z-index-Tour branch October 20, 2023 07:33
@MadCcc MadCcc mentioned this pull request Nov 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants