Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transition to spin fullscreen #45436

Merged
merged 1 commit into from Oct 20, 2023
Merged

feat: add transition to spin fullscreen #45436

merged 1 commit into from Oct 20, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Oct 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: add transition to spin fullscreen
🇨🇳 Chinese 给全屏状态的 spin 蒙层添加过渡

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 1e307a5

Improved the spin component's style, demo, and logic for fullscreen mode. Fixed a TypeScript error and added transition effects for the fullscreen spinner.

🔍 Walkthrough

🤖 Generated by Copilot at 1e307a5

  • Refactor demo code for fullscreen spin component to use clearer state variable, longer duration, and spinning prop (link)
  • Rename spin component style file from index.tsx to index.ts and remove empty export statement (link)
  • Add new CSS class name and rule for fullscreen spinner to control visibility and opacity based on fullscreen and spinning props (link, link)

@stackblitz
Copy link

stackblitz bot commented Oct 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 398.91 KB (+25 B 🔺)
./dist/antd-with-locales.min.js 458.22 KB (+28 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Oct 19, 2023, 5:29 PM

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cc223a1) 100.00% compared to head (1e307a5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #45436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          695       696    +1     
  Lines        11712     11721    +9     
  Branches      3131      3132    +1     
=========================================
+ Hits         11712     11721    +9     
Files Coverage Δ
components/spin/index.tsx 100.00% <100.00%> (ø)
components/spin/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 30c8e42 into feature Oct 20, 2023
96 checks passed
@afc163 afc163 deleted the spin branch October 20, 2023 08:28
@MadCcc MadCcc mentioned this pull request Nov 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants