Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(data-picker): add time-picker scrollbar styles #45478

Merged
merged 3 commits into from Oct 27, 2023
Merged

style(data-picker): add time-picker scrollbar styles #45478

merged 3 commits into from Oct 27, 2023

Conversation

GeorgeHcc
Copy link
Contributor

@GeorgeHcc GeorgeHcc commented Oct 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Describe the problem and the scenario:修改时间选择器滚动条样式

修改之前:
image
修改之后
in chrome:
image
in firefox:
image

📝 Changelog

Language Changelog
🇺🇸 English Modify the time picker scroll bar style
🇨🇳 Chinese 修改时间选择器滚动条样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at fa54a0c

Add custom webkit scrollbar styles for date picker panel in dark mode. This enhances the visual consistency and user experience of the components/date-picker component.

🔍 Walkthrough

🤖 Generated by Copilot at fa54a0c

  • Add custom styles for the webkit scrollbar of the date picker panel (link)

@stackblitz
Copy link

stackblitz bot commented Oct 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023

Preview Is ready

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ca2b54) 100.00% compared to head (6569db5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45478   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          694       694           
  Lines        11678     11678           
  Branches      3120      3120           
=========================================
  Hits         11678     11678           
Files Coverage Δ
components/date-picker/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kiner-tang kiner-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以把优化前后的样式对比图贴到 pr 的内容中

components/date-picker/style/index.ts Outdated Show resolved Hide resolved
@argos-ci
Copy link

argos-ci bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 22, 2023, 2:19 PM

@li-jia-nan
Copy link
Member

感觉 antd 里面很多组件都需要适配一下 win 系统,原生的滚动条在 win 上面太丑了

@kiner-tang kiner-tang merged commit 8c45c73 into ant-design:master Oct 27, 2023
62 checks passed
@li-jia-nan
Copy link
Member

li-jia-nan commented Oct 27, 2023

@kiner-tang @MadCcc 这些值不需要换成 token 吗?是不是需要考虑一下暗黑模式?

@MadCcc
Copy link
Member

MadCcc commented Oct 30, 2023

要用 token。另外滚动条样式应当统一,和虚拟列表的滚动条一致

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants