Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config-provider support rangePicker className and style properties #45479

Merged
merged 5 commits into from Oct 23, 2023
Merged

feat: config-provider support rangePicker className and style properties #45479

merged 5 commits into from Oct 23, 2023

Conversation

Yueyanc
Copy link
Contributor

@Yueyanc Yueyanc commented Oct 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#43051

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ConfigProvider support rangePicker className and style properties
🇨🇳 Chinese ConfigProvider 支持 rangePicker组件的 className 和 style 属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 2567579

This pull request adds a new feature to the ConfigProvider component to allow customizing the rangePicker component. It modifies the components/config-provider files to define and pass the rangePicker prop, and the components/date-picker files to use the prop for styling. It also updates the documentation and tests for the new feature.

🔍 Walkthrough

🤖 Generated by Copilot at 2567579

  • Add rangePicker prop to ConfigProvider component and ConfigContext to allow setting common props for the rangePicker component (link, link, link, link, link)
  • Use rangePicker prop from ConfigContext to apply common props to RangePicker component and its underlying RCRangePicker component (link, link, link)
  • Add test cases to verify that className and style props of rangePicker component can be configured through ConfigProvider component using TimePicker.RangePicker as an example (link)
  • Reorder and remove duplicate import of DrawerProps type in components/config-provider/context.ts file (link, link)

@stackblitz
Copy link

stackblitz bot commented Oct 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023

Preview Is ready

@Yueyanc Yueyanc changed the title Feat cp rangepicker feat: config-provider support rangePicker className and style properties Oct 22, 2023
@argos-ci
Copy link

argos-ci bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Oct 23, 2023, 4:41 PM

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7661ce) 100.00% compared to head (2567579) 100.00%.
Report is 16 commits behind head on feature.

❗ Current head 2567579 differs from pull request most recent head 63df2a5. Consider uploading reports for the commit 63df2a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #45479   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          696       696           
  Lines        11725     11725           
  Branches      3135      3135           
=========================================
  Hits         11725     11725           
Files Coverage Δ
components/config-provider/context.ts 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <ø> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan mentioned this pull request Oct 23, 2023
20 tasks
@li-jia-nan li-jia-nan merged commit d04e9ef into ant-design:feature Oct 23, 2023
50 checks passed
@MadCcc MadCcc mentioned this pull request Nov 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants