Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification duplicated style #45487

Merged
merged 1 commit into from Oct 23, 2023
Merged

fix: notification duplicated style #45487

merged 1 commit into from Oct 23, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Oct 23, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45482

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Notification duplicated style applied to wrapper.
🇨🇳 Chinese 修复 Notification 组件 style 属性会重复添加到外层的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at c8a4594

Updated rc-notification dependency to fix notification bug. This was part of a pull request that improved the ant-design UI library.

🔍 Walkthrough

🤖 Generated by Copilot at c8a4594

  • Updated the rc-notification dependency to fix a bug related to notification placement and animation (link)

@stackblitz
Copy link

stackblitz bot commented Oct 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Preview Is ready

@MadCcc MadCcc changed the title fix: notification duplicate style fix: notification duplicated style Oct 23, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-notification 5.3.0 None +0 81.3 kB

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 398.09 KB (+78 B 🔺)
./dist/antd-with-locales.min.js 457.4 KB (+86 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 23, 2023, 8:05 AM

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a340566) 100.00% compared to head (c8a4594) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          694       694           
  Lines        11678     11678           
  Branches      3120      3120           
=========================================
  Hits         11678     11678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 5f50a9e into master Oct 23, 2023
100 checks passed
@MadCcc MadCcc deleted the fix/notification-style branch October 23, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification 中的notice-wrapper 和 notice样式冲突
3 participants