New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SelectLike components support z-index manager #45494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-z-index-context #45494 +/- ##
==========================================================
Coverage 100.00% 100.00%
==========================================================
Files 697 697
Lines 11738 11740 +2
Branches 3138 3137 -1
==========================================================
+ Hits 11738 11740 +2
☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2ab55c9
Use the
useZIndex
hook to manage the zIndex of dropdown menus in various components. This hook respects the existing props and contexts that affect the zIndex, and ensures a consistent and compatible behavior across different components and scenarios. Simplify and activate the test cases for theuseZIndex
hook.🔍 Walkthrough
🤖 Generated by Copilot at 2ab55c9
components/_util/__tests__/useZIndex.test.tsx
file, to use specific consumer components (Dropdown and SelectLike) instead of all the possible ones, and to verify the functionality of the hook after the consumer components have been merged (link, link)