feat: ColorPicker support z-index manager #45496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-z-index-context #45496 +/- ##
==========================================================
Coverage 100.00% 100.00%
==========================================================
Files 697 697
Lines 11740 11741 +1
Branches 3137 3137
==========================================================
+ Hits 11740 11741 +1
☔ View full report in Codecov by Sentry. |
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
zombieJ
approved these changes
Oct 24, 2023
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 7069bec
This pull request refactors several components that use dropdown menus to use the
useZIndexhook for managing their zIndex values. This improves the consistency and compatibility of the zIndex values across different components and contexts. ThedropdownStyleprop is also simplified to avoid conflicts with the hook. TheuseZIndexhook is tested with specific consumer components.🔍 Walkthrough
🤖 Generated by Copilot at 7069bec
useZIndexhook in theauto-complete,cascader,color-picker,dropdown, andtree-selectcomponents to manage the zIndex of their dropdown menus or panels (link, link, link, link, link, link, link, link, link, link, link, link, link, link)zIndexContextin thedropdowncomponent to pass the context value from the hook to the children components that may also use the hook (link)dropdownStyleprop in theselectcomponent to only include the zIndex value from the hook, as the zIndex prop is not needed anymore (link)useZIndexhook to use specific consumer components instead of all the keys of theconsumerComponentobject, and enable the test case for testing the component (link, link)