feat: menu support z-index manager #45498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
|
|
|
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor-z-index-context #45498 +/- ##
==========================================================
Coverage 100.00% 100.00%
==========================================================
Files 697 697
Lines 11743 11744 +1
Branches 3137 3137
==========================================================
+ Hits 11743 11744 +1
☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Oct 24, 2023
| // const containers = ['Modal']; | ||
| const consumers = ['Dropdown']; | ||
| // const consumers = Object.keys(consumerComponent); | ||
| // const consumers = ['Dropdown', 'SelectLike', 'ColorPicker', 'DatePicker']; |
There was a problem hiding this comment.
好，我再合并到 feature 的时候清理一下
zombieJ
approved these changes
Oct 24, 2023
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2110df8
This pull request adds or updates a
useZIndexhook to several components that have popup or dropdown elements. The hook controls thezIndexstyle of the components based on their type and optional props. This improves the positioning and visibility of the components in different scenarios. The pull request also refactors some test and import code for better readability and reliability.🔍 Walkthrough
🤖 Generated by Copilot at 2110df8
useZIndexhook to assign and applyzIndexvalues to various components that have popup or dropdown elements, such asAutoComplete,Cascader,ColorPicker,DatePicker,Menu, andTreeSelect(link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)useZIndexhook inuseZIndex.test.tsxto enable testing all the possible consumer components, account for the special case of theTourcomponent, and prevent timeout errors (link, link, link, link, link)SubMenu.tsxto follow the convention of importing React first, then external modules, then internal modules (link)