New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): Prevented closing if menu is in multiple mode #45513
fix(Dropdown): Prevented closing if menu is in multiple mode #45513
Conversation
Run & review this pull request in StackBlitz Codeflow. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45513 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 694 694
Lines 11678 11680 +2
Branches 3120 3121 +1
=========================================
+ Hits 11678 11680 +2
☔ View full report in Codecov by Sentry. |
Signed-off-by: Vyacheslav Sedykh <zlav24va@mail.ru>
Could you add a test case? |
Do you mean formalized issue (#45520)? Or should I add some tests for my changes? |
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: Vyacheslav Sedykh <zlav24va@mail.ru>
Right, the original problem should be covered. |
Sorry, didn't catch you. |
We should add test case (such as https://github.com/ant-design/ant-design/blob/master/components/avatar/__tests__/Avatar.test.tsx ) for your changes, in case that the original problem happen again. |
Done |
When i upgrade to version 5.11.3 it still closes after clicking on an item, then i comback version 5.10.3 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #45520
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at d3240af
Fixed a bug in
dropdown.tsx
that caused the dropdown menu to close when selecting multiple options. Addedmenu
prop as a dependency toonMenuClick
function.🔍 Walkthrough
🤖 Generated by Copilot at d3240af
menu
prop as dependency toonMenuClick
function (link)