Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value for gap #45537

Merged
merged 1 commit into from Oct 26, 2023
Merged

fix: add default value for gap #45537

merged 1 commit into from Oct 26, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Oct 26, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Watermark that gap should have default value when passing undefined in array.
🇨🇳 Chinese 修复 Watermark 组件 gap 在数组中含有 undefined 时没有默认值的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at e36b448

Refactored the gap prop logic in the Watermark component to use cleaner and more consistent syntax. This improves the code quality and performance of the components/watermark/index.tsx file.

🔍 Walkthrough

🤖 Generated by Copilot at e36b448

  • Add constants for default gap values (link)
  • Use constants for default gap prop in Watermark component (link)
  • Handle undefined or incomplete gap prop with default values (link)

@stackblitz
Copy link

stackblitz bot commented Oct 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Preview Is ready

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 398.15 KB (+5 B 🔺)
./dist/antd-with-locales.min.js 457.47 KB (+6 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 26, 2023, 6:35 AM

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (15acef5) 100.00% compared to head (e36b448) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45537   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          694       694           
  Lines        11678     11694   +16     
  Branches      3120      3129    +9     
=========================================
+ Hits         11678     11694   +16     
Files Coverage Δ
components/watermark/index.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 62bb2fa into master Oct 26, 2023
97 checks passed
@MadCcc MadCcc deleted the fix/watermark-gap-default branch October 26, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants