Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Typography.Text lost right border when text is ellipsis #45575

Merged
merged 1 commit into from Oct 30, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 29, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #40261
close #40503
close #40967
close #41005

💡 Background and solution

图片

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography.Text lost right border when enable ellipsis and code.
🇨🇳 Chinese 修复 Typography.Text 同时启用 ellipsiscode 时丢失右边框样式的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 4d60df6

This pull request enhances the typography component and its demos by adding ellipsis support for code style, adjusting the width of the ellipsis demo, and improving the code formatting and readability.

🔍 Walkthrough

🤖 Generated by Copilot at 4d60df6

  • Increase the width of the text component with ellipsis and add another text component with code style and ellipsis in components/typography/demo/ellipsis.tsx (link)
  • Enable ellipsis and overflow handling for the code element inside the typography component and set its vertical alignment to bottom in components/typography/style/mixins.ts (link)
  • Add empty lines to separate the import statements, the component declaration, and the component usage in components/typography/demo/basic.tsx (link, link)
  • Add empty lines to separate the paragraphs and titles in components/typography/demo/basic.tsx (link, link, link)

@stackblitz
Copy link

stackblitz bot commented Oct 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Preview Is ready

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 398.33 KB (+33 B 🔺)
./dist/antd-with-locales.min.js 457.64 KB (+35 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Oct 29, 2023, 9:49 AM

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77f16cf) 100.00% compared to head (4d60df6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45575   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          694       694           
  Lines        11682     11682           
  Branches      3122      3122           
=========================================
  Hits         11682     11682           
Files Coverage Δ
components/typography/style/mixins.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 2dbc6ab into master Oct 30, 2023
98 checks passed
@afc163 afc163 deleted the style/fix-typography-code-ellipsis branch October 30, 2023 02:02
@MadCcc MadCcc mentioned this pull request Nov 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typography.Text code ellipsis 丢失右边框
3 participants