New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(color-picker): preset colors support collapsing at initialization #45607
Merged
MadCcc
merged 7 commits into
ant-design:feature
from
Wxh16144-forks:wuxh/color-picker-preset-collapsed
Nov 3, 2023
Merged
feat(color-picker): preset colors support collapsing at initialization #45607
MadCcc
merged 7 commits into
ant-design:feature
from
Wxh16144-forks:wuxh/color-picker-preset-collapsed
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Wxh16144
commented
Oct 31, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45607 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 699 699
Lines 11806 11810 +4
Branches 3149 3150 +1
=========================================
+ Hits 11806 11810 +4
☔ View full report in Codecov by Sentry. |
afc163
reviewed
Nov 1, 2023
RedJue
reviewed
Nov 1, 2023
Co-authored-by: RedJue <RedJue@users.noreply.github.com>
MadCcc
reviewed
Nov 3, 2023
MadCcc
reviewed
Nov 3, 2023
Signed-off-by: MadCcc <1075746765@qq.com>
MadCcc
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at f88d3a8
This pull request adds a new feature to the color picker component, which allows the user to specify the initial folding state of the presets using the
collapsed
property. It also refactors the code for generating and managing the collapse panel keys, and adds tests and documentation for the new feature.🔍 Walkthrough
🤖 Generated by Copilot at f88d3a8
collapsed
property topresets
prop of color picker component, allowing users to control the initial folding state of the presets (link, link, link)genCollapsePanelKey
helper function (link, link)genCollapsePanelKey
function (link)components/color-picker/__tests__/index.test.tsx
(link)