Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slider handler should be movable after click tracker #45651

Merged
merged 2 commits into from Nov 3, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 3, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

react-component/slider#948

close #43728

💡 Background and solution

图片

点击轨道直接移动鼠标时,滑块不会移动。MUI 则可以:https://mui.com/material-ui/react-slider/

before MUI After
Nov-03-2023 00-16-46 Nov-03-2023 00-16-34 Nov-03-2023 00-16-38

📝 Changelog

Language Changelog
🇺🇸 English Slider handler should be movable after click tracker.
🇨🇳 Chinese 优化 Slider 交互体验,点击轨道后可直接拖拽滑块。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 8b9bfab

Updated rc-slider dependency to fix slider component bugs. This was part of a larger dependency update for the ant-design UI library.

🔍 Walkthrough

🤖 Generated by Copilot at 8b9bfab

  • Updated several dependencies to fix issues and improve performance (link,

Copy link

stackblitz bot commented Nov 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@afc163 afc163 mentioned this pull request Nov 3, 2023
20 tasks
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Preview Is ready

@afc163 afc163 marked this pull request as ready for review November 3, 2023 07:22
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-slider 10.4.0 environment +0 149 kB afc163

Copy link

argos-ci bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 3, 2023, 7:42 AM

Copy link
Contributor

github-actions bot commented Nov 3, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 400.46 KB (+3 B 🔺)
./dist/antd-with-locales.min.js 459.79 KB (+6 B 🔺)

Signed-off-by: afc163 <afc163@gmail.com>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99138cb) 100.00% compared to head (008508a) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          699       699           
  Lines        11810     11810           
  Branches      3150      3150           
=========================================
  Hits         11810     11810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit f46587b into master Nov 3, 2023
90 checks passed
@MadCcc MadCcc deleted the fix/upgrade-slider branch November 3, 2023 08:29
@afc163
Copy link
Member Author

afc163 commented Nov 3, 2023

原来之前有人提过了:#43728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The slider does not move after clicking on a random spot on the track
3 participants