feat(form): focus first failed element #45739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibinko <tibor.hanesz@gmail.com>
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7e93b23:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45739 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 705 705
Lines 11996 12003 +7
Branches 3191 3194 +3
=========================================
+ Hits 11996 12003 +7
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Reference: #45701
💡 Background and solution
While the scrollToFirstError property provides a smooth scroll to the first field that encounters a validation error, it does not automatically set focus to this field. This can be a hindrance to accessibility, as users who rely on keyboard navigation will not automatically know which field has the error, especially after the page scrolls. Moreover, for screen reader users, the error message might not be read out if the focus does not shift to the input with the error.
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 7e93b23
This pull request adds a new feature to the
Formcomponent and theuseFormhook that allows users to focus a form field automatically or manually. It also updates the tests and the documentation for both the English and Chinese versions.🔍 Walkthrough
🤖 Generated by Copilot at 7e93b23
focusFirstErrorFieldto theFormcomponent, which enables focusing the first failed field when the form validation fails (link, link, link, link, link)focusFieldmethod in theuseFormhook, which finds and focuses the field by its name path and id (link, link)focusFirstErrorFieldprop in thecomponents/form/__tests__/index.test.tsxfile, which asserts that the input element has focus and theonFinishFailedcallback is called (link)