feat: menu support css variable theme #45750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
65 tasks
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d1dd17:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45750 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 706 706
Lines 12002 12128 +126
Branches 3199 3233 +34
==========================================
+ Hits 12002 12128 +126
☔ View full report in Codecov by Sentry. |
|
argos 上有变化了 |
MadCcc
reviewed
Nov 9, 2023
MadCcc
reviewed
Nov 9, 2023
MadCcc
reviewed
Nov 9, 2023
MadCcc
reviewed
Nov 9, 2023
MadCcc
reviewed
Nov 9, 2023
MadCcc
reviewed
Nov 9, 2023
MadCcc
reviewed
Nov 10, 2023
MadCcc
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 72681e7
This pull request adds CSS variable support to the menu component by using a custom hook and a utility library. It refactors the menu component style tokens and CSS objects to use the utility functions for handling units, arithmetic operations, and type aliases. It also fixes a typo in the RTL mode and improves the compatibility with different CSS units. The main files affected are
components/menu/menu.tsx,components/menu/style/index.tsx, andcomponents/menu/style/cssVar.ts.🔍 Walkthrough
🤖 Generated by Copilot at 72681e7
useCSSVarto register and use CSS variables for the menu component (link)useCSSVarinmenu.tsx,MenuDivider.tsx,MenuItem.tsx, andSubMenu.tsxand wrap the returned elements with the CSS variable provider (link,link,link,link,link,link,link,link,link,link,link,link,link)unitandtypefunctions from@ant-design/cssinjsto add unit suffixes to numeric values and declare type aliases for CSS objects inindex.tsx,horizontal.tsx,vertical.tsx, andtheme.tsx(link,link,link,link)index.tsxto allow unitless values and usetoken.calcandunitfunctions to perform arithmetic operations and add unit suffixes (link,link,link,link,link,link,link,link,link,link,link,link)prepareComponentTokeninindex.tsxto return the default token values for the menu component with dark mode and disabled state colors (link)prepareComponentTokenfunction call inindex.tsx(link,link)transformvalue for the submenu arrow in RTL mode inrtl.tsx(link)token.calcandunitfunctions intheme.tsxto perform arithmetic operations and add unit suffixes (link,link,link,link,link)token.calcandunitfunctions inhorizontal.tsxandvertical.tsxto perform arithmetic operations and add unit suffixes (link,link,link,link,link,link,link,link,link)