fix: Description children missing key #45757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
yoyo837
approved these changes
Nov 9, 2023
MadCcc
approved these changes
Nov 9, 2023
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 22c9eaa:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45757 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 700 700
Lines 11828 11828
Branches 3153 3153
=========================================
Hits 11828 11828
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
childrenstructure missing the Descriptions.Itemkeyprop.children结构语法糖时，会丢失 Descriptions.Item 的key的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 22c9eaa
This pull request fixes a react key prop error in the
Descriptionscomponent when using jsx mode. It adds a test case for theuseItemshook and modifies thetransChildren2Itemsfunction incomponents/descriptions/hooks/useItems.tsto preserve thekeyprop of theDescriptions.Itemcomponent.🔍 Walkthrough
🤖 Generated by Copilot at 22c9eaa
keyprop of theDescriptions.Itemcomponent to avoid react key prop error and identify the component (link)useItemshook to check that it does not throw a react key prop error when using jsx mode to render theDescriptions.Itemcomponent (link)