Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Affix support cssVar #45807

Merged
merged 5 commits into from
Nov 13, 2023
Merged

feat: Affix support cssVar #45807

merged 5 commits into from
Nov 13, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Nov 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: Affix support cssVar
🇨🇳 Chinese feat: 固钉组件支持 cssVar

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at c844f37

The pull request adds theme support for the Affix component by using CSS variables for styling. It introduces a new cssVar.ts file to export a custom hook for the component, and updates the index.tsx and style/index.ts files to use the hook and the theme helper functions.

🔍 Walkthrough

🤖 Generated by Copilot at c844f37

  • Import and use useCSSVar hook to register and apply CSS variables for Affix component (link, link, link)
  • Add cssVar.ts file to export useCSSVar hook for Affix component (link)
  • Import and export prepareComponentToken function to define and merge default token values for Affix component (link, link)

Copy link

stackblitz bot commented Nov 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 11, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 11, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 405.1 KB (+6 B 🔺)
./dist/antd-with-locales.min.js 464.57 KB (+7 B 🔺)

Copy link

codesandbox-ci bot commented Nov 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f83bbca:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86e3d37) 100.00% compared to head (f83bbca) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #45807   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          706       706           
  Lines        12046     12045    -1     
  Branches      3197      3197           
=========================================
- Hits         12046     12045    -1     
Files Coverage Δ
components/affix/index.tsx 100.00% <100.00%> (ø)
components/affix/style/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

argos-ci bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 1 change Nov 13, 2023, 10:44 AM

@MadCcc MadCcc merged commit c8637cf into feature Nov 13, 2023
92 of 93 checks passed
@MadCcc MadCcc deleted the cssvar-affix branch November 13, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants