Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add jsDoc for cssVar calculator #45809

Merged
merged 4 commits into from
Nov 13, 2023
Merged

chore: add jsDoc for cssVar calculator #45809

merged 4 commits into from
Nov 13, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Nov 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 无需纳入ChangeLog
🇨🇳 Chinese 无需纳入ChangeLog

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 8cefdeb

Added Chinese comments for AbstractCalculator methods in components/theme/util/calc/calculator.ts. Moved class declaration to follow comments.

🔍 Walkthrough

🤖 Generated by Copilot at 8cefdeb

  • Add comments for abstract methods of AbstractCalculator class in Chinese (link)
  • Move class declaration after comments and before export statement (link)

Copy link

stackblitz bot commented Nov 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 11, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 11, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 403.77 KB
./dist/antd-with-locales.min.js 463.18 KB

Copy link

codesandbox-ci bot commented Nov 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 435f5ad:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Nov 12, 2023, 6:10 AM

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (047bc53) 100.00% compared to head (435f5ad) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #45809   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          706       706           
  Lines        12015     12015           
  Branches      3202      3202           
=========================================
  Hits         12015     12015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 55bb516 into feature Nov 13, 2023
91 checks passed
@zombieJ zombieJ deleted the jsDoc branch November 13, 2023 01:58
@MadCcc MadCcc mentioned this pull request Nov 13, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants