fix: QRCode style.padding should work #45815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a75e92c:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
afc163
force-pushed
the
fix/qrcode-padding
branch
from
3070be8
to
c0184c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #45815 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 700 700
Lines 11833 11833
Branches 3155 3155
=========================================
Hits 11833 11833
☔ View full report in Codecov by Sentry. |
crazyair
reviewed
Nov 12, 2023
crazyair
reviewed
Nov 12, 2023
crazyair
approved these changes
Nov 12, 2023
afc163
commented
Nov 12, 2023
afc163
force-pushed
the
fix/qrcode-padding
branch
2 times, most recently
from
fbdb5f2
to
db96681
Compare
afc163
force-pushed
the
fix/qrcode-padding
branch
2 times, most recently
from
e0f4686
to
8412209
Compare
afc163
force-pushed
the
fix/qrcode-padding
branch
from
8412209
to
8f95928
Compare
zombieJ
reviewed
Nov 13, 2023
zombieJ
approved these changes
Nov 13, 2023
20 tasks
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #45801
💡 Background and solution
这个修改后，将可以通过
或者
修改默认的 padding。
📝 Changelog
style.paddingis not working.style.padding时无效的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 3070be8
This pull request fixes a bug in the
QRCodecomponent that ignored thestyle.paddingprop. It adds a helper function to handle different padding formats and a test case to verify the component's behavior.🔍 Walkthrough
🤖 Generated by Copilot at 3070be8
style.paddingprop (link, link)getQrCodePaddingto calculate the padding value from different types and formats of the prop incomponents/qr-code/index.tsx(link)style.paddingprop incomponents/qr-code/__tests__/index.test.tsxto check the width and height of the canvas element with different values of padding (link)