Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Tweak carousel dots radius #45817

Merged
merged 1 commit into from Nov 13, 2023
Merged

style: Tweak carousel dots radius #45817

merged 1 commit into from Nov 13, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 12, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

改成圆角:
图片

📝 Changelog

Language Changelog
🇺🇸 English Tweak Carousel dots border radius style.
🇨🇳 Chinese 调整 Carousel 切换条圆角样式。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 328cefb

Adjusted the shape of the carousel dots to match the design specs by using the dotHeight token for the borderRadius property in components/carousel/style/index.ts.

🔍 Walkthrough

🤖 Generated by Copilot at 328cefb

  • Make carousel dots more circular by using dotHeight token for borderRadius property (link)

Copy link

stackblitz bot commented Nov 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 12, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 400.83 KB (+1 B 🔺)
./dist/antd-with-locales.min.js 460.17 KB (+1 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 328cefb:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 4 changes Nov 12, 2023, 9:50 AM

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0424f3) 100.00% compared to head (328cefb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45817   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11833     11833           
  Branches      3155      3155           
=========================================
  Hits         11833     11833           
Files Coverage Δ
components/carousel/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit abd73e0 into master Nov 13, 2023
101 checks passed
@MadCcc MadCcc deleted the style/dot-radius branch November 13, 2023 01:43
@PeachScript PeachScript mentioned this pull request Nov 17, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants