feat: Carousel support cssVar #45837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
65 tasks
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a2c2caa:
|
MadCcc
reviewed
Nov 13, 2023
MadCcc
approved these changes
Nov 13, 2023
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
size-limit report 📦
|
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: 红果汁 <pingfj77@gmail.com>
RedJue
force-pushed
the
feat-cssvar-carousel
branch
from
ff0c864
to
a2c2caa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45837 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 706 706
Lines 12015 12044 +29
Branches 3202 3197 -5
=========================================
+ Hits 12015 12044 +29
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 9404e04
This pull request refactors the Carousel component to use CSS variables for theming, instead of inline styles. It introduces a new
useCSSVarhook that registers and updates the CSS variables based on the theme tokens, and uses the@ant-design/cssinjspackage to improve the style flexibility and consistency. It affects the filescomponents/carousel/index.tsx,components/carousel/style/index.ts, andcomponents/carousel/style/cssVar.ts.🔍 Walkthrough
🤖 Generated by Copilot at 9404e04
useCSSVarthat registers and updates CSS variables for the Carousel component based on the theme tokens (link)useCSSVarhook in the Carousel component and replace thewrapSSRfunction with thewrapCSSVarfunction returned by the hook (link, link, link)unitfunction from the@ant-design/cssinjspackage and use it to format some of the Carousel token values that are numbers (link, link)CarouselTokeninterface to accept either a string or a number for some of the properties and use thetoken.calcmethod to perform arithmetic operations on the token values (link, link, link, link)prepareComponentTokenfunction from theuseCarouselStylehook and reuse it in theuseCSSVarhook (link, link)