-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: popconfirm support css var #45840
refactor: popconfirm support css var #45840
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Hi @c0dedance. Thanks for your contribution. The path |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a73ca8b:
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45840 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 706 706
Lines 12052 12054 +2
Branches 3197 3197
=========================================
+ Hits 12052 12054 +2
☔ View full report in Codecov by Sentry. |
Signed-off-by: MadCcc <madccc@foxmail.com>
Signed-off-by: MadCcc <1075746765@qq.com>
Signed-off-by: MadCcc <1075746765@qq.com>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#45618
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at dfe4068
Refactored the popconfirm component to use a custom hook for registering and wrapping CSS variables. This improves code readability and consistency, and reduces the dependency on the theme package.
🔍 Walkthrough
🤖 Generated by Copilot at dfe4068
useStyle
andwrapSSR
imports and functions touseCSSVar
andwrapCSSVar
respectively, to avoid confusion and indicate usage of CSS variables in popconfirm component (link, link, link, link)cssVar.ts
file to exportgenCSSVarRegister
function that creates a custom hook for registering and wrapping the CSS variables for the popconfirm component (link)GetDefaultToken
type from theme package and extract and exportprepareComponentToken
function fromgenComponentStyleHook
call instyle/index.tsx
file, to generate the default token for the popconfirm component that includes thezIndexPopup
value (link, link)popconfirm
entry fromcheckCSSVar
function inscripts/check-cssinjs.tsx
script, because the popconfirm component no longer uses theuseStyle
hook from the theme package (link)