feat: Collapse support cssVar #45862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
65 tasks
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
MadCcc
reviewed
Nov 14, 2023
|
lint 看下 |
我看看 |
RedJue
force-pushed
the
feat-cssvar-collapse
branch
from
bd72f1f
to
b5e882c
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1c2fdef:
|
MadCcc
approved these changes
Nov 14, 2023
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #45862 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 706 706
Lines 12078 12079 +1
Branches 3197 3197
=========================================
+ Hits 12078 12079 +1 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Nov 14, 2023
MadCcc
reviewed
Nov 14, 2023
components/collapse/style/index.ts
Outdated
| @@ -95,7 +100,7 @@ export const genBaseStyle: GenerateStyle<CollapseToken> = (token) => { | |||
| alignItems: 'flex-start', | |||
| padding: headerPadding, | |||
| color: colorTextHeading, | |||
| lineHeight, | |||
| lineHeight: lineHeightLG, | |||
There was a problem hiding this comment.
这里不用改哦，应该是 large 的 Collapse 才需要改
There was a problem hiding this comment.
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: 红果汁 <pingfj77@gmail.com>
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: 红果汁 <pingfj77@gmail.com>
RedJue
force-pushed
the
feat-cssvar-collapse
branch
from
b7cdb79
to
7c9645c
Compare
|
|
好 我再改下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 804ab6b
This pull request refactors the Collapse component to use CSS variables for styling, improving the code quality and maintainability. It introduces a new
useCSSVarhook incomponents/collapse/style/cssVar.tsthat registers and applies the CSS variables dynamically. It also simplifies the style code incomponents/collapse/style/index.tsby using utility functions and properties from the theme module.🔍 Walkthrough
🤖 Generated by Copilot at 804ab6b
useCSSVarhook to register and apply CSS variables for Collapse component (link, link, link, link)unitfunction to ensure consistent units for CSS variables and style properties (link, link, link, link)token.calcmethod to simplify margin calculations (link, link)fontHeightproperty to simplify height settings (link, link)prepareComponentTokenfunction to generate default token values for Collapse component (link, link)