Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled btn with link should not be focused #45910

Merged
merged 3 commits into from Nov 16, 2023
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Nov 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button with href and disabled that could be focused.
🇨🇳 Chinese 修复 Button 带有链接且禁用时可以被聚焦到的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at 6fe5aa9

Added tabIndex attribute to button.tsx to control keyboard focus. Prevented disabled buttons from being focusable for accessibility.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at 6fe5aa9

  • Add tabIndex attribute to button element to control keyboard focus order and prevent disabled buttons from receiving focus (link)

Copy link

stackblitz bot commented Nov 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 16, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 321.26 KB (-236 B 🔽)
./dist/antd-with-locales.min.js 367.07 KB (-87 B 🔽)

Copy link

codesandbox-ci bot commented Nov 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a6c55c9:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 16, 2023, 3:04 AM

@MadCcc
Copy link
Member Author

MadCcc commented Nov 16, 2023

这 bundlesize 小在哪了

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab4863c) 100.00% compared to head (a6c55c9) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45910   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11831     11832    +1     
  Branches      3154      3155    +1     
=========================================
+ Hits         11831     11832    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 2dda417 into master Nov 16, 2023
92 checks passed
@MadCcc MadCcc deleted the fix/btn-focus branch November 16, 2023 03:36
@MadCcc MadCcc mentioned this pull request Nov 17, 2023
20 tasks
@PeachScript PeachScript mentioned this pull request Nov 17, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants