New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export sider context from layout for v4 #45947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peach <scdzwyxst@gmail.com>
Run & review this pull request in StackBlitz Codeflow. |
MadCcc
approved these changes
Nov 17, 2023
Signed-off-by: Peach <scdzwyxst@gmail.com>
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Size Limit 挂掉看起来是 |
afc163
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
v5: #45916
💡 Background and solution
Export
SiderContext
fromLayout
, to avoid multi-instance problem when usingProLayout
and externalantd
at the same time, ref: https://github.com/ant-design/pro-components/blob/8b451c6e255fecced11e7d7b0be4aad2bfa0a09c/packages/layout/src/components/SiderMenu/SiderMenu.tsx#L5📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖[deprecated] Generated by Copilot at a048100
Exposed
SiderContext
as aLayout
property to allow customSider
configurations. Renamed and typed the property for consistency and safety.🔍 Walkthrough
🤖[deprecated] Generated by Copilot at a048100
SiderContext
as a property ofLayout
component for customizingSider
behavior (link, link, link)SiderContext
from./Sider
incomponents/layout/index.tsx
(link)SiderContext
as a type ofCompoundedComponent
interface (link)SiderContext
as a property ofLayout
component using_InternalSiderContext
name (link)