Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled link button should not have navigate when right click #46021

Merged
merged 2 commits into from Nov 22, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Nov 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45904

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button that disabled link button should not have navigate options when right click.
🇨🇳 Chinese 修复禁用的链接按钮右键点击时会有打开新链接选项的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at a91b8ee

Fix disabled link button bug in button.tsx. Add condition to href prop to prevent navigation when button is disabled.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at a91b8ee

  • Prevent disabled link buttons from being clickable (link)

Copy link

stackblitz bot commented Nov 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 22, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 324.09 KB (-21 B 🔽)
./dist/antd-with-locales.min.js 369.8 KB (-159 B 🔽)

Copy link

codesandbox-ci bot commented Nov 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f985b9c:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 22, 2023, 12:59 PM

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce9041b) 100.00% compared to head (f985b9c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46021   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11853     11854    +1     
  Branches      3160      3161    +1     
=========================================
+ Hits         11853     11854    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 08a85d2 into master Nov 22, 2023
94 checks passed
@MadCcc MadCcc deleted the fix/disabled-link-btn branch November 22, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants