Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollup warning #46024

Merged
merged 1 commit into from Nov 22, 2023
Merged

fix: rollup warning #46024

merged 1 commit into from Nov 22, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #46022

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Resolve Card get Rollup warning for invalid annotation.
🇨🇳 Chinese 解决 Card 在 Rollup 中会警告 invalid annotation 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at c2c6194

This pull request improves the code style and logic of Card.tsx by reordering imports and refactoring key generation.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at c2c6194

  • Reorder imports to follow convention of React, external, internal modules (link)
  • Refactor key generation for list items in getAction function to avoid using array index and disabling eslint rule (link)

Copy link

stackblitz bot commented Nov 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 22, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 324.14 KB (+53 B 🔺)
./dist/antd-with-locales.min.js 370.03 KB (+239 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c2c6194:

Sandbox Source
antd reproduction template (forked) Configuration
fervent-lucy-x9z56m Issue #46022

Copy link

argos-ci bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 22, 2023, 1:26 PM

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08a85d2) 100.00% compared to head (c2c6194) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46024   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11854     11855    +1     
  Branches      3161      3161           
=========================================
+ Hits         11854     11855    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 110e1b3 into master Nov 22, 2023
102 checks passed
@zombieJ zombieJ deleted the fix-rollup branch November 22, 2023 14:01
nnmax pushed a commit to nnmax/ant-design that referenced this pull request Nov 22, 2023
jsxiaosi added a commit to jsxiaosi/react-xs-admin that referenced this pull request Dec 12, 2023
- 修复vite5 打包,ant组件组件注释位置导致Rollup 无法解释该注释出现控制台警告(ant-design/ant-design#46024
@chengshaohui
Copy link

最新的vite^5.0.5 和最新的antd^5.12.4 引入Form组件 build时还是会有一行警告“in "node_modules/rc-field-form/es/utils/validateUtil.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants