fix(Radio, Checkbox): export required prop type
#46028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
nnmax
force-pushed
the
feat/radio-required
branch
from
5150c9a
to
c079f68
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90a1ca6:
|
nnmax
force-pushed
the
feat/radio-required
branch
from
c079f68
to
e797f21
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46028 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 700 700
Lines 11855 11855
Branches 3161 3161
=========================================
Hits 11855 11855 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Nov 23, 2023
nnmax
force-pushed
the
feat/radio-required
branch
from
e797f21
to
90a1ca6
Compare
afc163
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #46025
💡 Background and solution
📝 Changelog
requiredprop of the Radio and Checkbox Componentsrequired属性的类型定义☑️ Self-Check before Merge
🚀 Summary
🤖[deprecated] Generated by Copilot at 5150c9a
This pull request adds a new
requiredprop to theCheckboxandRadiocomponents and their respective groups, allowing users to mark them as mandatory for form validation. It also updates the documentation and demos for both components in English and Chinese to reflect the new feature.🔍 Walkthrough
🤖[deprecated] Generated by Copilot at 5150c9a
requiredprop to theCheckboxandRadiocomponents and their group variants, which enables the native form validation for the inputs when they are set totrue(link, link, link, link)requiredprop from theoptionsarray to the individualCheckboxandRadiocomponents inside theCheckbox.GroupandRadio.Groupcomponents, respectively, to apply the validation to each option (link, link)requiredprop and its type and functionality in the English and Chinese versions of the documentation for theCheckboxandRadiocomponents and their group variants (components/checkbox/index.en-US.md,components/checkbox/index.zh-CN.md,components/radio/index.en-US.md,components/radio/index.zh-CN.md) (link, link, link, link, link, link, link)basic.tsxdemo file for theCheckboxcomponent to showcase the usage and effect of therequiredprop with bothCheckboxandRadiocomponents in a form (components/checkbox/demo/basic.tsx) (link, link)