Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: remove form ref usage from demo #46046

Merged
merged 1 commit into from Nov 23, 2023
Merged

demo: remove form ref usage from demo #46046

merged 1 commit into from Nov 23, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 23, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Form 在 function component 和 class component 下的两种用法,在功能上对用户没啥区别,不需要重复展示。单独放一个 codesandbox 链接就好。

现在演示很多了,截图和构建都有时间成本,也应该梳理一下。

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at 5aa5eb9

The pull request removes the outdated code examples of using ref in class component with Form component from the documentation, and adds a codesandbox link to show how to use ref in class component. This is to avoid confusion and simplify the documentation.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at 5aa5eb9

  • Delete control-ref.md and control-ref.tsx files that contain outdated code examples of using ref to get the form instance in class component (link, link)
  • Remove the same code examples from the Examples and 代码演示 sections of index.en-US.md and index.zh-CN.md files respectively (link, link)
  • Add a link to a codesandbox example that shows how to use ref in class component as an alternative solution for users who are not using functional components or hooks, to both the English and Chinese versions of control-hooks.md file (link, link)

Copy link

stackblitz bot commented Nov 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 23, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 324.14 KB
./dist/antd-with-locales.min.js 369.91 KB

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5aa5eb9:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 23, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 23, 2023, 10:02 AM

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea56970) 100.00% compared to head (5aa5eb9) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46046   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11855     11855           
  Branches      3160      3160           
=========================================
  Hits         11855     11855           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 9f9f64e into master Nov 23, 2023
104 checks passed
@afc163 afc163 deleted the demo/remove-form-demo branch November 23, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants