feat: Tab Item support icon prop #46096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Signed-off-by: lijianan <574980606@qq.com>
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cd3303f:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #46096 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 708 708
Lines 12171 12171
Branches 3204 3204
=========================================
Hits 12171 12171 ☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Nov 27, 2023
MadCcc
reviewed
Nov 28, 2023
MadCcc
reviewed
Nov 28, 2023
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: lijianan <574980606@qq.com>
Co-authored-by: MadCcc <madccc@foxmail.com> Signed-off-by: lijianan <574980606@qq.com>
MadCcc
approved these changes
Nov 28, 2023
ANM699
reviewed
Feb 19, 2024
| @@ -740,7 +740,7 @@ const genTabStyle: GenerateStyle<TabsToken, CSSObject> = (token: TabsToken) => { | |||
| [`& ${tabCls}-remove ${iconCls}`]: { | |||
| margin: 0, | |||
| }, | |||
| [iconCls]: { | |||
| [`${iconCls}:not(:last-child)`]: { | |||
| marginRight: { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖[deprecated] Generated by Copilot at 76c76ae
Added the
iconproperty to theTabscomponent and its documentation. This allows users to specify icons for each tab head and improves the icon alignment and spacing. Updated therc-tabsdependency to enable this feature.🔍 Walkthrough
🤖[deprecated] Generated by Copilot at 76c76ae
iconproperty toTabItemTypeinterface andTabscomponent to display icons on tab heads (link, link, link)genTabStylefunction to add margin to icon element for better spacing and alignment (link)components/tabs/demo/icon.tsxto useiconproperty instead oflabelfor icons (link)