Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump antd-tools version #46103

Merged
merged 3 commits into from Nov 27, 2023
Merged

chore: bump antd-tools version #46103

merged 3 commits into from Nov 27, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Nov 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English [MISC] Fix error in dist.
🇨🇳 Chinese [MISC] 修复打包 dist 产物错误。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at 902943b

This pull request improves the performance and reliability of the documentation site by using a smaller previewer bundle and updating the theme generation tool.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at 902943b

  • Reduce previewer bundle size by using minified antd-with-locales.js file (link)
  • Update @ant-design/tools dependency to fix theme generation issues (link)

Copy link

stackblitz bot commented Nov 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 27, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 324.49 KB
./dist/antd-with-locales.min.js 370.67 KB

Copy link

codesandbox-ci bot commented Nov 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3626c88:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 27, 2023, 9:43 AM

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f566a0) 100.00% compared to head (3626c88) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11857     11857           
  Branches      3161      3161           
=========================================
  Hits         11857     11857           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member Author

MadCcc commented Nov 27, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 324.49 KB
./dist/antd-with-locales.min.js 370.67 KB

因为 antd-tools 发的 patch 所以这里反映不出变化,大概是多了 100B 左右。

webpack 默认在生产模式下开启了 concatenateModules,之前又重复开启了一遍这个插件,导致在 webpack5 下产生了问题,重复 concat 了一些 module,结果就是这些 moduleId 为 null。

多出来的 100B 应该是被重复 concat 的模块,尺寸变化是预期的。

@MadCcc MadCcc merged commit 0e360ed into master Nov 27, 2023
97 checks passed
@MadCcc MadCcc deleted the chore/bump-antd-tools branch November 27, 2023 09:53
@MadCcc MadCcc mentioned this pull request Nov 27, 2023
20 tasks
@afc163
Copy link
Member

afc163 commented Nov 27, 2023

为啥测试没测出来?

@MadCcc
Copy link
Member Author

MadCcc commented Nov 27, 2023

为啥测试没测出来?

应该是没有测 min.js 所以漏了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants