Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InputNumber addon in compact #46130

Merged
merged 2 commits into from Nov 28, 2023
Merged

fix: InputNumber addon in compact #46130

merged 2 commits into from Nov 28, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Nov 28, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45764

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix style of InputNumber with addon inside Space.Compact.
🇨🇳 Chinese 修复 InputNumber 带有 addon 时在 Space.Compact 下使用的样式问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Nov 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 324.5 KB (+50 B 🔺)
./dist/antd-with-locales.min.js 370.66 KB (+53 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 71fc137:

Sandbox Source
antd reproduction template (forked) Configuration
紧凑模式 - antd@5.11.0 (forked) Issue #45764

Copy link

argos-ci bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Nov 28, 2023, 8:50 AM

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb40c38) 100.00% compared to head (71fc137) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        11872     11872           
  Branches      3161      3161           
=========================================
  Hits         11872     11872           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 082975e into master Nov 28, 2023
109 checks passed
@MadCcc MadCcc deleted the fix/input-number-compact branch November 28, 2023 09:11
@vagusX vagusX mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputNumber 在 Space.Compact 中如果存在 addonAfter 边框展示不对
2 participants