Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form label tooltip icon trigger Switch #46155

Merged
merged 2 commits into from Nov 30, 2023
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 29, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46154

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix that clicking Form tooltip icon should not trigger Switch.
🇨🇳 Chinese 修复点击 Form tooltip 图标会触发 Switch 切换的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Nov 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Nov 29, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 324.46 KB (+17 B 🔺)
./dist/antd-with-locales.min.js 370.66 KB (-5 B 🔽)

Copy link

codesandbox-ci bot commented Nov 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed29654:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 29, 2023, 8:18 AM

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aed105b) 100.00% compared to head (ed29654) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        11872     11874    +2     
  Branches      3161      3161           
=========================================
+ Hits         11872     11874    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyair
Copy link
Member

Changelog 没有提到 Form

@MadCcc MadCcc merged commit 7488c58 into master Nov 30, 2023
106 checks passed
@MadCcc MadCcc deleted the fix/form-label-behavior branch November 30, 2023 01:53
@MadCcc MadCcc mentioned this pull request Nov 30, 2023
20 tasks
@vagusX vagusX mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants