Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Alert background could be linear-gradient #46188

Merged
merged 1 commit into from Nov 30, 2023
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 30, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

截屏2023-11-30 下午3 38 47

📝 Changelog

Language Changelog
🇺🇸 English Alert could support linear-gradient background by colorInfoBg token.
🇨🇳 Chinese Alert 的背景色现在可以通过 colorInfoBg token 定义为渐变色。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Nov 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Preview Is ready

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 324.72 KB (+3 B 🔺)
./dist/antd-with-locales.min.js 370.71 KB (+70 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02ead97:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 30, 2023, 7:49 AM

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1235d8f) 100.00% compared to head (02ead97) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          701       701           
  Lines        11874     11874           
  Branches      3161      3161           
=========================================
  Hits         11874     11874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Nov 30, 2023

这么酷的吗

@afc163 afc163 merged commit 6d963b7 into master Nov 30, 2023
110 checks passed
@afc163 afc163 deleted the fix/colorInfoBg branch November 30, 2023 10:03
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@zombieJ
Copy link
Member

zombieJ commented Nov 30, 2023

花里胡哨,我喜欢

<ConfigProvider
theme={{
token: {
colorInfoBg: 'linear-gradient(90deg, #84fab0, #8fd3f4)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

等其他组件改了 background 是不是都会变成渐变色了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦 这里只包了一个 Alert,一个组件也要用 ConfigProvider 配置吗,不能在 Alert 配置吗

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

组件上现在还没有 theme 属性。

@MadCcc MadCcc mentioned this pull request Nov 30, 2023
20 tasks
@vagusX vagusX mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants