Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Notification title overlaps with the close icon when it is too long #46211

Merged
merged 1 commit into from Dec 4, 2023

Conversation

zh-lx
Copy link
Contributor

@zh-lx zh-lx commented Dec 1, 2023

Fix the issue where the notification title overlaps with the close icon when it is too long.
close #46179.

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46179

💡 Background and solution

When the notification title is too long, it will overlap with the close icon.

📝 Changelog

Language Changelog
🇺🇸 English Fix the issue where the notification title overlaps with the close icon when it is too long
🇨🇳 Chinese 修复 notification 标题太长时会与 close 图标重叠的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Preview Is ready

Copy link

codesandbox-ci bot commented Dec 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9cce92b:

Sandbox Source
antd reproduction template (forked) Configuration

@MadCcc
Copy link
Member

MadCcc commented Dec 4, 2023

等一下 feature 合并到 master,再 rebase 一下

Fix the issue where the notification title overlaps with the title when it is too long

Signed-off-by: zhoulixiang <18366276315@163.com>
@MadCcc MadCcc merged commit 4f9c576 into ant-design:master Dec 4, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification 标题过长时文本显示在关闭图标下面
3 participants