feat(Search): added disable button for Search Input #46254
Conversation
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 47f794c:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #46254 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 708 708
Lines 12108 12110 +2
Branches 3211 3213 +2
=========================================
+ Hits 12108 12110 +2 ☔ View full report in Codecov by Sentry. |
| @@ -107,6 +107,7 @@ The rest of the props of `Input.TextArea` are the same as the original [textarea | |||
| | Property | Description | Type | Default | | |||
| | --- | --- | --- | --- | | |||
| | enterButton | Whether to show an enter button after input. This property conflicts with the `addonAfter` property | boolean \| ReactNode | false | | |||
There was a problem hiding this comment.
enterButton={<Button disabled>submit</Button>}
Is it enough?
There was a problem hiding this comment.
That could also work but it i think it would be nice to be able to control the already made button.
Or instead of my feature, should i create a new proprety (like buttonProps) that could send props directly to the Button?
There was a problem hiding this comment.
enterButton accept a ReactNode like <Button /> so that we can prevent another enterButtonProps.
There was a problem hiding this comment.
Same as disabledEnterButton, that is what we don't wanna see.
There was a problem hiding this comment.
Ok then , i guess that this PR can be closed
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Added the ability to disable the Enter Button on Search Input.
📝 Changelog
Added the disableEnterButton propriety that allows the enter button to be disabled.
Updated the tests + documentation + demo to show this change.
☑️ Self-Check before Merge