Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tour arrowPointAtCenter could be configured #46301

Merged
merged 1 commit into from Dec 7, 2023
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 7, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45936

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tour that pointAtCenter of arrow not work.
🇨🇳 Chinese 修复 Tour 组件 arrow 属性下修改 pointAtCenter 不生效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Preview Is ready

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@rc-component/tour 1.12.0 None +0 60.3 kB

Copy link
Contributor

github-actions bot commented Dec 7, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 328.63 KB (+66 B 🔺)
./dist/antd-with-locales.min.js 374.37 KB (-59 B 🔽)

Copy link

codesandbox-ci bot commented Dec 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 19123b9:

Sandbox Source
antd reproduction template (forked) Configuration
位置 - antd@5.11.0 (forked) Issue #45936

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71bd883) 100.00% compared to head (19123b9) 100.00%.
Report is 19 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46301   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12106     12112    +6     
  Branches      3211      3212    +1     
=========================================
+ Hits         12106     12112    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit a4286e1 into feature Dec 7, 2023
103 checks passed
@MadCcc MadCcc deleted the fix/tour-arrow branch December 7, 2023 05:57
Copy link
Contributor

github-actions bot commented Dec 7, 2023

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants