refactor: color-picker panel dom logic #46327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
20 tasks
|
有 BreakChange 风险 🤔 |
MadCcc
changed the title
# Conflicts: # components/color-picker/__tests__/__snapshots__/index.test.tsx.snap # components/color-picker/demo/panel-render.tsx # components/form/__tests__/__snapshots__/demo-extend.test.ts.snap # components/table/InternalTable.tsx
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 097d170:
|
Visual Regression Report for PR #46327
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #46327 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 709 709
Lines 12148 12148
Branches 3225 3225
=========================================
Hits 12148 12148 ☔ View full report in Codecov by Sentry. |
MadCcc
approved these changes
Dec 15, 2023
|
compact 主题下有 diff |
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # components/color-picker/__tests__/__snapshots__/demo-extend.test.ts.snap
本地跑了一下视觉回归，这个变动是符合预期的。（该 PR 的 demo 相比于之前少了一个 
|
MadCcc
approved these changes
Dec 18, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
ref: #45527 (comment)
💡 Background and solution
将原来
.ant-color-picker-inner-content类名 拆为 2 个，分别.ant-color-picker-inner和.ant-color-picker-inner-content.ant-color-picker-inner: 表示这个面板容器，与面板有关的样式写这个类名下。
.ant-color-picker-inner-content： 默认为 antd 颜色选择器面板容器。该类名只存在覆写 antd 内部样式。
如果开发者通过
panelRender完全自定义内容时，默认插入到.ant-color-picker-inner容器下，而不是.ant-color-picker-inner-content.(这样就可以避免样式冲突。📝 Changelog
ColorPickerpopup panel dom tree logicColorPicker弹出面板 dom tree 逻辑☑️ Self-Check before Merge