Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Breadcrumb items type #46399

Merged

Conversation

rapsealk
Copy link
Contributor

@rapsealk rapsealk commented Dec 12, 2023

Hi ant-design!

This PR updates the type of Breadcrumb's items property, from items[] to ItemType[].

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Update the type of Breadcrumb's items on document.
🇨🇳 Chinese 更新文档上面包屑项目的类型。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Preview Is ready

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dbb338:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link
Contributor

Visual Regression Report for PR #46399

Target branch: master (82777bc)


Congrats! No visual-regression diff found

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82777bc) 100.00% compared to head (0dbb338) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12108     12108           
  Branches      3211      3211           
=========================================
  Hits         12108     12108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit 89712f2 into ant-design:master Dec 12, 2023
77 of 78 checks passed
@rapsealk rapsealk deleted the docs/update-breadcrumb-items-type branch December 12, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants