Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(theme): improve built-in component style #46414

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Dec 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese 改进内置组件样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Preview Is ready

Copy link

codesandbox-ci bot commented Dec 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a80a702:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Visual Regression Report for PR #46414

Target branch: master (acbbbfe)


Congrats! No visual-regression diff found

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (acbbbfe) 100.00% compared to head (0e9e315) 100.00%.

❗ Current head 0e9e315 differs from pull request most recent head a80a702. Consider uploading reports for the commit a80a702 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46414   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12120     12120           
  Branches      3217      3217           
=========================================
  Hits         12120     12120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Dec 13, 2023

样式和官方组件不太一样:https://ant.design/components/alert-cn#components-alert-demo-icon

@Wxh16144
Copy link
Member Author

https://ant.design/components/alert-cn#components-alert-demo-icon

我无脑 copy 了, 晚点我重新搞一下~

@Wxh16144

This comment was marked as off-topic.

@afc163
Copy link
Member

afc163 commented Dec 17, 2023

ci 挂了

@MadCcc MadCcc merged commit b7cf72d into ant-design:master Dec 18, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants