Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Checkbox style when customize token.lineWidth #46431

Merged
merged 3 commits into from Dec 13, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Dec 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #46307

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Checkbox style when customize token.lineWidth
🇨🇳 Chinese 修复 Checkbox 自定义 token.lineWidth 时勾选箭头错位问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Visual Regression Report for PR #46431

Target branch: master (b3b5df4)


Congrats! No visual-regression diff found

@afc163
Copy link
Member Author

afc163 commented Dec 13, 2023

@MadCcc 还有个问题,lineWidth 自定义在 cssVar 模式下不生效:https://codesandbox.io/p/sandbox/withered-browser-qn4c5g?file=%2Fsrc%2FApp.js%3A20%2C36

Copy link
Contributor

github-actions bot commented Dec 13, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 328.43 KB (-325 B 🔽)
./dist/antd-with-locales.min.js 374.38 KB (+49 B 🔺)

Copy link

codesandbox-ci bot commented Dec 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8a90a7:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3b5df4) 100.00% compared to head (a8a90a7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46431   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12108     12108           
  Branches      3211      3211           
=========================================
  Hits         12108     12108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 12db874 into master Dec 13, 2023
106 checks passed
@afc163 afc163 deleted the style/checkbox-line-width branch December 13, 2023 13:46
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@MadCcc
Copy link
Member

MadCcc commented Dec 14, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox边框宽度不为1的时候,选中状态对勾会偏移
4 participants