New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Upload accessibility experience #46432
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Visual Regression Report for PR #46432 Failed ❌
Check Full Report for details |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
size-limit report 📦
|
e394fa4
to
ef6da69
Compare
ef6da69
to
c5bcd40
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cfe8085:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #46432 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 708 708
Lines 12120 12122 +2
Branches 3218 3220 +2
=========================================
+ Hits 12120 12122 +2 ☔ View full report in Codecov by Sentry. |
有点猜的味道,是不是可以优化成监听 focus 事件,在 focus 时看内部是否有可以聚焦的元素,如果有的话就 proxy 到子元素中。用这个方法: |
需要添加 react-component/upload#518 的文档 |
这个方式有 DOM 查询的副作用,不太想这么搞。 |
|
Conflicting |
083aa0f
to
4e2ff38
Compare
4e2ff38
to
cfe8085
Compare
ant-upload-drag由display:table改为了display:flex,这样做的原因是什么,突然发现页面的样式被改变 |
#46810 改回去了,等发布 |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #46215
close #24771
close #45922
💡 Background and solution
修复 Upload 包裹 Button 时需要 tab 两次的问题。基于 react-component/upload#521
hasControlInside
因为大多数时候是和 Button 一起配合使用。hasControlInside
,因为拖拽上传的 children 一般不是 Button。hasControlInside
,因为这个属性比较难理解,一般无需关注。📝 Changelog
☑️ Self-Check before Merge