Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: import virsual diff report table styles #46433

Merged
merged 1 commit into from
Dec 13, 2023
Merged

test: import virsual diff report table styles #46433

merged 1 commit into from
Dec 13, 2023

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Dec 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

使 3 列顶部对齐

image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Visual Regression Report for PR #46433

Target branch: master (b3b5df4)
View Full Report


image name expected actual diff
qr-code-Popover.png master: b3b5df442cbdc81f201f593b8612d0ebf5da4cf2 current: pr-46433 diff

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 328.75 KB
./dist/antd-with-locales.min.js 374.34 KB

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c81aaf:

Sandbox Source
antd reproduction template (forked) Configuration

@afc163
Copy link
Member

afc163 commented Dec 13, 2023

什么效果?

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3b5df4) 100.00% compared to head (5c81aaf) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46433   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12108     12108           
  Branches      3211      3211           
=========================================
  Hits         12108     12108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Dec 13, 2023

宽度不一样,导致内容图片尺寸不一,可以把列宽固定了

@crazyair
Copy link
Member Author

crazyair commented Dec 13, 2023

宽度不一样,导致内容图片尺寸不一,可以把列宽固定了

宽度是一部分,也有一部分是内容

image

可以调试这个页面 https://antd-visual-diff.oss-cn-shanghai.aliyuncs.com/pr-46398/visualRegressionReport/report.html 看下宽度都是800,但是高度不一样

@afc163 afc163 changed the title styles: report add top styles test: import virsual diff report table styles Dec 13, 2023
@crazyair crazyair merged commit a3ec293 into master Dec 13, 2023
118 of 119 checks passed
@crazyair crazyair deleted the report-css branch December 13, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants