Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Progress): StrokeLinecap style #46551

Merged
merged 1 commit into from Dec 22, 2023
Merged

Conversation

ZN1996
Copy link
Contributor

@ZN1996 ZN1996 commented Dec 20, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #46535

💡 Background and solution

问题描述:
当Process组件 type 属性为“line”时,设置其 strokeLinecap 属性为“butt”后,进度条样式显示不正确。

解决思路:
在代码中根据 strokeLinecap 属性的值来决定是否设置进度条的圆角半径。

📝 Changelog

Language Changelog
🇺🇸 English Fix strokeLinecap style
🇨🇳 Chinese 修复strokeLinecap属性对应样式

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Visual Regression Report for PR #46551 Passed ✅

Target branch: master (5393d9c)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Preview Is ready

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1458d88:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5393d9c) 100.00% compared to head (1458d88) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46551   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        12120     12121    +1     
  Branches      3217      3218    +1     
=========================================
+ Hits         12120     12121    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 142b4d7 into ant-design:master Dec 22, 2023
63 checks passed
@MadCcc MadCcc mentioned this pull request Dec 22, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

progress line does not show the right strokeLinecap
2 participants