Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: form support variant #46573

Merged
merged 1 commit into from Dec 22, 2023
Merged

feat: form support variant #46573

merged 1 commit into from Dec 22, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 21, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form support variant to control components variant inside.
🇨🇳 Chinese Form 新增 variant 属性用于控制内部组件变体。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Visual Regression Report for PR #46573

Target branch: feature (5f395fb)
View Full Report


image name expected actual diff
date-picker-bordered.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
date-picker-bordered.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
date-picker-status.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
date-picker-status.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
form-validate-static.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
form-validate-static.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
mentions-status.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
mentions-status.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
time-picker-bordered.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
time-picker-bordered.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e ⛔️⛔️⛔️ Missing ⛔️⛔️⛔️ 🚨🚨🚨 Removed 🚨🚨🚨
time-picker-status.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff
time-picker-status.css-var.png feature: 5f395fbed39f02aa5377e154b2b5fd9fd4c5e58e current: pr-46573 diff

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 329.75 KB (+86 B 🔺)
./dist/antd-with-locales.min.js 375.73 KB (+30 B 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a316d8:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf70858) 100.00% compared to head (2a316d8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46573   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          717       717           
  Lines        12204     12205    +1     
  Branches      3221      3222    +1     
=========================================
+ Hits         12204     12205    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

预览链接的样式好像是挂的

image

@MadCcc
Copy link
Member Author

MadCcc commented Dec 22, 2023

预览链接的样式好像是挂的

image

网络问题

@MadCcc MadCcc merged commit 924f46f into feature Dec 22, 2023
109 checks passed
@MadCcc MadCcc deleted the feat/form-variant branch December 22, 2023 02:05
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants