Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component style without hash #46609

Merged
merged 7 commits into from Jan 30, 2024
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Dec 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #47132
close #47182

💡 Background and solution

image
剩一些 a 标签相关样式,由于没有容器所以部分样式没有套上去,实际场景中问题不大,有 App 包裹。

📝 Changelog

Language Changelog
🇺🇸 English MISC: Fix component style without hash.
🇨🇳 Chinese 杂项:修复无 hash 模式下的组件样式。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Visual Regression Report for PR #46609 Passed ✅

Target branch: master (c61870e)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Preview Is ready

Copy link
Contributor

github-actions bot commented Dec 25, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 331.51 KB (+30 B 🔺)
./dist/antd-with-locales.min.js 377.48 KB (+219 B 🔺)

Copy link

codesandbox-ci bot commented Dec 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5613c59:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ecc0d7) 100.00% compared to head (5613c59) 100.00%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #46609   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          732       732           
  Lines        12563     12566    +3     
  Branches      3295      3298    +3     
=========================================
+ Hits         12563     12566    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

li-jia-nan
li-jia-nan previously approved these changes Jan 17, 2024
@li-jia-nan
Copy link
Member

这么多 commit 都带上来了

@MadCcc MadCcc force-pushed the chore/test-css-var-without-hash branch from 51625d5 to 3d5b4e2 Compare January 29, 2024 07:58
@MadCcc MadCcc changed the title chore: image test without hash fix: component style without hash Jan 29, 2024
@MadCcc MadCcc marked this pull request as ready for review January 30, 2024 02:29
@MadCcc MadCcc merged commit 441ba5f into master Jan 30, 2024
107 checks passed
@MadCcc MadCcc deleted the chore/test-css-var-without-hash branch January 30, 2024 03:08
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

@afc163
Copy link
Member

afc163 commented Jan 30, 2024

有啥办法避免这个问题么

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submenu label is not visible when hashed is false Large <Button>'s icon size is incorrect with hashed: false
4 participants