Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config support container #46616

Closed
wants to merge 5 commits into from
Closed

feat: config support container #46616

wants to merge 5 commits into from

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Dec 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

静态组件 message Modal notification 无法设置 hashPriority="high":where 降级等,先增加 container 方法,让用户自定义包裹

ConfigProvider.config({
  container: (children) => <StyleProvider hashPriority="high">{children}</StyleProvider>,
});
image
  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English ConfigProvider.config support container
🇨🇳 Chinese ConfigProvider.config 支持 container

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Visual Regression Report for PR #46616 Passed ✅

Target branch: feature (28aaeaf)


Congrats! No visual-regression diff found

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Preview Is ready

@crazyair crazyair changed the base branch from master to feature December 25, 2023 13:43
@ant-design ant-design deleted a comment from socket-security bot Dec 25, 2023
Copy link
Contributor

github-actions bot commented Dec 25, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 330.18 KB (+123 B 🔺)
./dist/antd-with-locales.min.js 375.98 KB (+160 B 🔺)

Copy link

codesandbox-ci bot commented Dec 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7e929cb:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28aaeaf) 100.00% compared to head (c910b6b) 100.00%.

❗ Current head c910b6b differs from pull request most recent head 7e929cb. Consider uploading reports for the commit 7e929cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46616   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        12209     12266   +57     
  Branches      3224      3232    +8     
=========================================
+ Hits         12209     12266   +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyair crazyair mentioned this pull request Dec 26, 2023
20 tasks
@crazyair crazyair changed the title feat: config support container test feat: config support containe Dec 26, 2023
@crazyair crazyair changed the title feat: config support containe feat: config support container Dec 26, 2023
@crazyair crazyair closed this Dec 26, 2023
@afc163 afc163 deleted the config-2 branch March 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant